Skip to content

validate DRPolicy Conflicts after updating PeerClasses and remove region field from ramendev config #2001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ShyamsundarR merged 3 commits into from
May 21, 2025
Merged

validate DRPolicy Conflicts after updating PeerClasses and remove region field from ramendev config #2001

ShyamsundarR merged 3 commits into from
May 21, 2025

Conversation

@rakeshgm
Copy link
Member

@rakeshgm rakeshgm commented Apr 9, 2025 •
edited
Loading

  • Validate DRPolicy Conflicts after updating PeerClasses.
  • Remove region field from ramendev config
  • add fakeMCV to DRPolicy tests

@rakeshgm
Copy link
Member Author

rakeshgm commented Apr 9, 2025

This PR might be needed for MetroDR, as SupportsMetro decision needs PeerClasses in drpolicy, if region is not available.

@rakeshgm rakeshgm force-pushed the deprecate-region-cont branch 3 times, most recently from 4d8edfd to 042412c Compare April 14, 2025 19:09
@ShyamsundarR ShyamsundarR mentioned this pull request Apr 17, 2025
Merged
@rakeshgm rakeshgm force-pushed the deprecate-region-cont branch 5 times, most recently from 20f68b8 to 63f646d Compare April 24, 2025 10:41
@rakeshgm rakeshgm force-pushed the deprecate-region-cont branch from 63f646d to b039116 Compare April 24, 2025 10:45
@rakeshgm
Copy link
Member Author

rakeshgm commented Apr 24, 2025 •
edited
Loading

I have the tests locally. The unit tests are passing.

make test
/home/rakesh/projects/ramen2/ramen/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
/home/rakesh/projects/ramen2/ramen/bin/controller-gen rbac:roleName=operator-role crd:generateEmbeddedObjectMeta=true webhook paths="./..." output:crd:artifacts:config=config/crd/bases
hack/install-setup-envtest.sh
go: sigs.k8s.io/controller-runtime/tools/[email protected] requires go >= 1.22.0; switching to go1.23.8
go test ./... -coverprofile cover.out
        github.com/ramendr/ramen/hack/fakes             coverage: 0.0% of statements
        github.com/ramendr/ramen/cmd            coverage: 0.0% of statements
        github.com/ramendr/ramen/internal/controller/core               coverage: 0.0% of statements
        github.com/ramendr/ramen/internal/controller/kubeobjects/velero         coverage: 0.0% of statements
ok      github.com/ramendr/ramen/internal/controller    131.137s        coverage: 64.4% of statements
ok      github.com/ramendr/ramen/internal/controller/cel        7.556s  coverage: [no statements]
ok      github.com/ramendr/ramen/internal/controller/cephfscg   10.139s coverage: 64.6% of statements
ok      github.com/ramendr/ramen/internal/controller/hooks      0.063s  coverage: 46.2% of statements
ok      github.com/ramendr/ramen/internal/controller/kubeobjects        0.042s  coverage: 33.3% of statements

I am not sure why the unit tests in the CI are failing..

BenamarMk
BenamarMk reviewed Apr 24, 2025
View reviewed changes
rakeshgm and others added 2 commits April 24, 2025 21:43
@rakeshgm
move validatePolicyConflicts()
fb0085a 
move validatePolicyConflicts() after updating
drpolicy.PeerClasses

Signed-off-by: rakeshgm <[email protected]>
@ShyamsundarR @rakeshgm
add fakeMCV to DRPolicy tests
0ff2794 
Signed-off-by: Shyamsundar Ranganathan <[email protected]>
@rakeshgm rakeshgm force-pushed the deprecate-region-cont branch from b039116 to 0ff2794 Compare April 24, 2025 16:16
@ShyamsundarR ShyamsundarR merged commit 875925b into RamenDR:main May 21, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenamarMk BenamarMk BenamarMk approved these changes

@ELENAGER ELENAGER ELENAGER approved these changes

@ShyamsundarR ShyamsundarR Awaiting requested review from ShyamsundarR ShyamsundarR is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rakeshgm @BenamarMk @ELENAGER @ShyamsundarR